Import Circle Game (used for testsuite) #177
Conversation
| @@ -75,3 +75,4 @@ obj~ | |||
| # This is used for local paths to SpacetimeDB packages. | |||
| /nuget.config | |||
| /nuget.config.meta | |||
| .idea/ | |||
There was a problem hiding this comment.
unrelated change: This ignores the jetbrains .idea/ directory which is created when opening the project in rider.
| <ItemGroup> | ||
| <None Update="logo.png" Pack="true" PackagePath="" /> | ||
| <None Update="README.md" Pack="true" PackagePath="" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Explicitly include all .cs files except Unity-related scripts --> | ||
| <ItemGroup> | ||
| <Compile Include="src/**/*.cs" Exclude="unity-tests/client/Assets/**/*.cs" /> |
There was a problem hiding this comment.
This prevents the unity testsuite cs files from being compiled during the dotnet testsuite.
.npmignore
Outdated
| @@ -0,0 +1 @@ | |||
| unity-tests/ | |||
There was a problem hiding this comment.
this prevents the unity-tests directory from being downloaded when a user imports our SDK
There was a problem hiding this comment.
I don't think .npmignore is respected for Git deps? IIUC Unity just uses Git clone, which doesn't have a way to exclude individual folders. We can only use the ~ suffix to exclude files and folders from assets, which you're already doing after the latest commits.
|
This comment also applies to this precursor PR: #176 (comment) |
|
I am going to evaluate whether this should be a submodule prior to merging this. |
Centril
force-pushed
the
jdetter/unity-testsuite-import
branch
from
a06a580 to
e174841
Compare
|
Rebased this atop of staging (trivial conflict to resolve, rc1 instead of 0.12.*) |
lcodes
force-pushed
the
jdetter/unity-testsuite-import
branch
from
e174841 to
3048408
Compare
|
closed in favor of using this as a submodule #186 |
Description of Changes
Describe what has been changed, any new features or bug fixes
API
If the API is breaking, please state below what will break
Requires SpacetimeDB PRs
List any PRs here that are required for this SDK change to work
None
Testing
Write instructions for a test that you performed for this PR
proof this builds: